block: fix infinite loop in badblocks_clear()#770
Open
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Open
block: fix infinite loop in badblocks_clear()#770blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
Conversation
Author
|
Upstream branch: dd6c438 |
Author
|
Upstream branch: dd6c438 |
blktests-ci
Bot
force-pushed
the
series/1085681=>linus-master
branch
from
02d2577 to
b27d89c
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
857ada9 to
482ce5b
Compare
Author
|
Upstream branch: dca922e |
blktests-ci
Bot
force-pushed
the
series/1085681=>linus-master
branch
from
b27d89c to
ded6f5d
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
482ce5b to
5a9f7c7
Compare
Author
|
Upstream branch: e75a43c |
blktests-ci
Bot
force-pushed
the
series/1085681=>linus-master
branch
from
ded6f5d to
6fdf687
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
5a9f7c7 to
25a041f
Compare
Author
|
Upstream branch: 66edb90 |
blktests-ci
Bot
force-pushed
the
series/1085681=>linus-master
branch
from
6fdf687 to
d15b186
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
25a041f to
6f75bd1
Compare
Author
|
Upstream branch: 6d35786 |
blktests-ci
Bot
force-pushed
the
series/1085681=>linus-master
branch
from
d15b186 to
b9f253f
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
6f75bd1 to
1f0d33a
Compare
Author
|
Upstream branch: 6d35786 |
blktests-ci
Bot
force-pushed
the
series/1085681=>linus-master
branch
from
b9f253f to
6fe6147
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
1f0d33a to
b1870f6
Compare
An infinite loop can occur in _badblocks_clear() when BB_OFFSET(p[prev + 1])
equals bad.start, resulting in len = 0. This causes the update_sectors loop
to spin forever without making progress:
s += 0; // no advancement
sectors -= 0; // stays positive
goto re_clear; // infinite loop
The bug exists in two code paths:
1. _badblocks_clear() at line 1153 (behind overlap check)
2. _badblocks_check() at line 1240 (behind overlap check)
Add checks in both functions to ensure len is non-zero before entering
the loop.
Signed-off-by: Ramesh Adhikari <adhikari.resume@gmail.com>
Author
|
Upstream branch: aa54b1d |
blktests-ci
Bot
force-pushed
the
series/1085681=>linus-master
branch
from
6fe6147 to
0416c2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: block: fix infinite loop in badblocks_clear()
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1085681